Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge can split messages #24

Closed
konnorandrews opened this issue Feb 4, 2018 · 0 comments · Fixed by #25
Closed

Bridge can split messages #24

konnorandrews opened this issue Feb 4, 2018 · 0 comments · Fixed by #25
Labels

Comments

@konnorandrews
Copy link
Member

Bug report

The Bridges can fail to read a message if it lands on a buffer boundary.

[0|message name|]...[3|data|test|message|] -> [0, message name, undefined/0]

Context

utils/cpp/comm and utils/javascript/comm

Process

  1. Use a Hub to send a large message
  2. Receive the message with a very low buffer size on the Port
  3. The Stream will correctly wait for entire strings to be completed
  4. The Bridge will only read part of the message, and error on the rest

Expected result

The Bridge should wait for the entire message to be received.

Current result

The Bridge will only read part of a message if it lands on a buffer boundary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant