Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app playground: search never terminates #817

Open
rubenfiszel opened this issue Jan 6, 2025 · 1 comment
Open

app playground: search never terminates #817

rubenfiszel opened this issue Jan 6, 2025 · 1 comment

Comments

@rubenfiszel
Copy link

Using the app playground, adding:
...getSearchServiceOverride()

and even adding in the worker factory:

                LocalFileSearchWorker: () =>
                    new Worker(
                        new URL(
                            "@codingame/monaco-vscode-search-service-override/worker",
                            import.meta.url
                        ),
                        { type: "module" }
                    ),
  1. LocalFileSearchWorker never seems to be loaded
  2. The search never terminates even though it displays some result (search icon shows a loader and a progress bar is forever loading at top)
  3. Only the search from opened tab shows in the search result, not files of the workspace that have not been opened in the editor
@CGNonofr
Copy link
Collaborator

CGNonofr commented Jan 6, 2025

LocalFileSearchWorker never seems to be loaded

It's only used for local search (ie using the HTMLFileSystemProvider as main file fs provider)

The search never terminates even though it displays some result (search icon shows a loader and a progress bar is forever loading at top)

Yes, the only existing implementations are the local (see 1) one and the node one (via a worker). When using the lib, no implementation exists on the virtual filesystem. You can implement it yourself though, like what was done on the monaco-vscode-api demo ; it only relies on open models though, so it can probably be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants