Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPC Drops #8

Open
Tomm0017 opened this issue Mar 21, 2019 · 4 comments
Open

NPC Drops #8

Tomm0017 opened this issue Mar 21, 2019 · 4 comments
Assignees

Comments

@Tomm0017
Copy link
Owner

Add a drop system for npcs

@Tomm0017 Tomm0017 self-assigned this Mar 21, 2019
@notmeta
Copy link

notmeta commented Mar 26, 2019

I'd suggest making a DSL for this which would allow for all sorts of possibilities which are not possible to represent in JSON, such as dropping an item with a given rarity if a particular quest is at a certain stage while wielding a specific item.

That being said since kotlinscript is heavily used already perhaps drops could be done using kts plugins instead.

@Tomm0017
Copy link
Owner Author

@notmeta Been thinking of the best way to approach it. A global npc drop system may not be worth it, but still thinking it over. It's either

  1. Define all drops as plugins in KotlinScript (similar to how all drops are defined on 07)
  2. Define "misc" drops for npcs externally and handle complex drops through plugins

@notmeta
Copy link

notmeta commented Mar 26, 2019

@notmeta It's either

1. Define all drops as plugins in KotlinScript (similar to how all drops are defined on 07)

2. Define "misc" drops for npcs externally and handle complex drops through plugins

@Tomm0017 Personally I'd keep them all in one place and go for the former choice.
It might be the more cumbersome option but it keeps users asking "I can't find the drops for X" and emulating what RS does is the best choice when... emulating RS

@Tomm0017
Copy link
Owner Author

@notmeta I was also leaning towards that option, so will probably move forward with that. Thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants