Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old verification email links are not invalidated #51

Open
Jumpy-Squirrel opened this issue Feb 13, 2023 · 1 comment
Open

Old verification email links are not invalidated #51

Jumpy-Squirrel opened this issue Feb 13, 2023 · 1 comment
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@Jumpy-Squirrel
Copy link
Collaborator

Creating a new verification link does not invalidate the old one, making it possible to end up with an email address different from the one last entered into the form if verification links are clicked out of the order they were originally created in.

@Thiritin
Copy link
Owner

Thiritin commented Feb 13, 2023

I will add a hash of the old email to the url and will check for this hash to be correct. Otherwise it will be rejected. I will also check uniqueness of the email on the controller.

Edit: won't do, too much complexity for little gain.

@Thiritin Thiritin added bug Something isn't working wontfix This will not be worked on labels Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants