Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private Items #10

Open
Friss opened this issue Apr 22, 2015 · 5 comments
Open

Private Items #10

Friss opened this issue Apr 22, 2015 · 5 comments

Comments

@Friss
Copy link
Contributor

Friss commented Apr 22, 2015

Should just be another checkbox on the item field and we only show it to the user if checked.

@corbanmailloux
Copy link
Member

So I have part of this working, but I can't make the tags respect it. The tags for private items will still display on the profile.

I also can't make the form work correctly. The "private" field isn't being saved.

It also makes badges kind of weird, but I guess we could always base them on only public items.

You can take a look at what I did on the private-items branch.

@Friss
Copy link
Contributor Author

Friss commented Apr 23, 2015

I believe I got it working now that the tags will only be for the items that are publicly available.

I also had to explicitly save the Private vs Non Private on the form submission. I'm not sure if this is a django thing with checkboxes or have to do with our hardcoded forms.

I also fixed a bug that wouldn't show the checkbox as checked if it was supposed to be.

@corbanmailloux
Copy link
Member

Nice.

I'm thinking that, related to this, we should separate the public and private items when you're looking at your own profile. That way, the user can tell what other people can see.

@Friss
Copy link
Contributor Author

Friss commented Apr 23, 2015

Perhaps an icon to say that it's private. Idk about splitting them up completely.

On April 23, 2015 9:49:18 AM EDT, Corban Mailloux [email protected] wrote:

Nice.

I'm thinking that, related to this, we should separate the public and
private items when you're looking at your own profile. That way, the
user can tell what other people can see.


Reply to this email directly or view it on GitHub:
#10 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

@corbanmailloux
Copy link
Member

That's probably a better idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants