-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Private Items #10
Comments
So I have part of this working, but I can't make the tags respect it. The tags for private items will still display on the profile. I also can't make the form work correctly. The "private" field isn't being saved. It also makes badges kind of weird, but I guess we could always base them on only public items. You can take a look at what I did on the private-items branch. |
I believe I got it working now that the tags will only be for the items that are publicly available. I also had to explicitly save the Private vs Non Private on the form submission. I'm not sure if this is a django thing with checkboxes or have to do with our hardcoded forms. I also fixed a bug that wouldn't show the checkbox as |
Nice. I'm thinking that, related to this, we should separate the public and private items when you're looking at your own profile. That way, the user can tell what other people can see. |
Perhaps an icon to say that it's private. Idk about splitting them up completely. On April 23, 2015 9:49:18 AM EDT, Corban Mailloux [email protected] wrote:
Sent from my Android device with K-9 Mail. Please excuse my brevity. |
That's probably a better idea. |
Should just be another checkbox on the item field and we only show it to the user if checked.
The text was updated successfully, but these errors were encountered: