-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No longer accepting plaintext only frameworks / Limited number of tests mutations #8420
Comments
Rules like these show how popular the project is and I agree with both. |
@nbrady-techempower on the number of mutations I proposed #8055 some time ago but then left it given the community feedbacks. It might be worth a while re-check it |
I like it a lot, but it exist a problem long ago. Like I said before the Rounds need to be immutable. |
One framework to remove: Baratine. The domain baratine.io is not registered to the project anymore (careful, clickbait!), and the github project has last changes 7 years ago (https://github.com/baratine/baratine) |
In reality Baratine is marked as Stripped. Why not bypass all the stripped frameworks from the runs ?? |
I disagree. In xitca-web Stripped bench is used to avoid polluting the default leaderboard while keep perf tracking of low level system software like OS and lang(and/or program) runtime at the same time. In fact Stripped is a fairly arbitrary category because there are even more unrealistic bench marked as Realistic. Unless there is a unified standard to determine what bench must be Stripped or not it's unfair to bypass them. |
@fakeshadow Ok. And about the what need to be Stripped, I think that it's a work of all the devs here, help to clarify the requirements and also to identify the frameworks than bypass these requirements. |
Unfortunately the meaning of "Realistic" is subjective and from the existing bench code it's clear we have very divided opinions among bench maintainers. Therefore I doubt a common ground can be reached easily. |
one thing i have been thinking is not quite fair is to combine results from different framework mutations together into the composite score. surely composite score should reflect a single configuration and that configuration's performance across all benches? for example, if we look at ntex, which was top of the last official round, the different flavours get wildly different scores across the different benchmarks. is it fair to pick the best mutation in each category and combine those for composite? is it even possible to run a single service on ntex which would score highly across all benches? it doesn't seem so, but this is surely what the composite score should be measuring? maybe a better system would be to sum up the scores across all benchmarks for a particular mutation and then, for each framework, choose the mutation that got the best composite score? maybe this has been raised before. sorry for bringing it up again if so. |
I agree with you on the composite score issue. Besides incompatible features it's a common practice in the bench that frameworks implement low level Speaking of |
Should we remove frameworks like gnet? It only implements plaintext and isn't actually doing any parsing / routing - it just scans to the \r\n\r\n and sends a canned response which doesn't meet the test requirements. |
@MarkReedZ , your project also has bugs: |
@remittor The point is to report issues, not to personally attack people |
Where do you think I went from reporting bugs to making personal attacks?
Your message #9055 (comment) is more suitable for attack than my results of @MarkReedZ code review |
This is a statement about a project
This is a statement that is personal
True! |
Hi everyone!
As the number of new frameworks submitted to the benchmarks grows, the amount of time it takes to complete a full run does as well. Because of this, we will be implementing the following rules:
New frameworks that only implement plaintext will no longer be accepted. Of course, we'd like all frameworks to implement all tests to get a better idea of performance in various areas of the framework, but we expect at least 2 different tests to be implemented. Ideally plaintext or json and one db test.
The number of test mutations will be limited to 10. We do not mind if you open up pull requests between runs to try out various mutations for your framework so long as the total number at any given time does not exceed 10.
After the next round, we will ping framework maintainers to make these changes. We will also look to remove tests that are older and no longer maintained.
Thank you!
The text was updated successfully, but these errors were encountered: