Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

footnote anchor weirdness #718

Open
sydb opened this issue Dec 2, 2024 · 4 comments
Open

footnote anchor weirdness #718

sydb opened this issue Dec 2, 2024 · 4 comments
Assignees
Labels

Comments

@sydb
Copy link
Member

sydb commented Dec 2, 2024

For TEI#2621 I was looking at chapter SG. I noticed that the numeric footnote anchors are way too high, and look like they are hovering over an em dash. I believe they are encoded in the HTML as

<span id="NoteNN_return">
  <a class="notelink" title="" href="javascript:void(0)" onclick="showPopupFootnote('NoteNN')">
    <sup>FF</sup>
  </a>
</span>

I think the em-dash-like-thingy is actually just underscoring. Either way, it is really ugly. Here it is at 200%:
image
And, in case you think the enlargement is causing the problem, here it is at 100%:
image

@sydb sydb added this to the Release 7.58.0 milestone Dec 2, 2024
@GusRiva GusRiva self-assigned this Dec 16, 2024
@GusRiva
Copy link
Member

GusRiva commented Dec 16, 2024

For some reason the class notelink does not have any css associated with it.
I will add it in a PR

@GusRiva
Copy link
Member

GusRiva commented Dec 16, 2024

There also seems to be conflicted rules for sup.

In guidelines.css :

sup {
    vertical-align: top;
    font-size: 70%;
}

In teic.css :

sub,
sup {
  position: relative;
  font-size: 0.75em;
  line-height: 0;
  vertical-align: baseline;
}

sup {
  top: -0.5em;
}

Both are applied to the guidelines html version, as guidelines.css imports teic.css .

The version in teic.css is newer, made by @hcayless 3 months ago. The version in guidelines.css is older, 17 years ago by Sebastian Rahtz

If we remove the instructions in guidelines.css the links are at the correct height.

There remains the issue of the underlined, but that should be done directly for the class notelink

@GusRiva
Copy link
Member

GusRiva commented Dec 16, 2024

I checked the epub version and there everything looks well, so we don't need to change those css files.

@GusRiva
Copy link
Member

GusRiva commented Dec 16, 2024

PR: TEIC/TEI#2636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants