Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support all hookScripts keys directly (don't force configs to use hookScripts[...] directly) #1385

Open
wwlwpd opened this issue Sep 10, 2024 · 2 comments
Assignees
Labels
configurability misc-francine assortment of UX improvements and efforts resulting in issues during hurricane Francine UX

Comments

@wwlwpd
Copy link
Collaborator

wwlwpd commented Sep 10, 2024

Turn this,

hooksScripts[FINISH_SPINUP_SCENARIO]=" output/createOPeNDAPFileList.sh output/$OPENDAPPOST "
hooksScripts[FINISH_NOWCAST_SCENARIO]=" output/createOPeNDAPFileList.sh output/$OPENDAPPOST "
...

into this,

FINISH_SPINUP_SCENARIO=( output/createOPeNDAPFileList.sh output/$OPENDAPPOST )
FINISH_NOWCAST_SCENARIO=( output/createOPeNDAPFileList.sh output/$OPENDAPPOST )
...

Which is how POSTPROCESS=( ... ) is currently handled.

@jasonfleming
Copy link
Collaborator

I agree, I like this better. The way it is now is just what I thought of first.

@wwlwpd
Copy link
Collaborator Author

wwlwpd commented Sep 10, 2024

I've been wanting to make this consistent for a while, "raw" access is fine for what we do here. It's a good time to make it consistent, though. I can't really blame this for me forgetting to add it in the latest configs.

@wwlwpd wwlwpd added the misc-francine assortment of UX improvements and efforts resulting in issues during hurricane Francine label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configurability misc-francine assortment of UX improvements and efforts resulting in issues during hurricane Francine UX
Projects
None yet
Development

No branches or pull requests

2 participants