-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
restructure PSU design variables as input files #127
Comments
Make sure that some guard is added to ensure that users are not mistakenly using old files when copying projects from previous years. Perhaps make year explicit as a stratification column in data preparation. |
These are sampling parameters for data recorded in biotic files. So one natural option would be to simply store them in the existing directory "biotic". Another natural option would be to store them in a new directory, called "design". |
Discussion with AJH and EJ on Oct 21 reaffirmed that we want this as input data, rather than resource files. We decided on the option og storing sampling parameters for biotic data in the biotic data file. No changes are necessary for any other StoX packages. Rework PSU sampling parameters as input data, and not process data. Make the convention about where to locate files clear. Put that path as an example in the function documentation reading them in, and give explicit instructions in vignette. |
implement ReadPSUSamplingParameters: as DefinePSUSamplingParameters with DefinitionMethod 'resourceFile', but without processdata options implement ComputePSUSamplingParameters: as DefinePSUSamplingParameters with DefinitionMethod 'AdHocStoxBiotic', but without processdata options. Keep DefinitionMethod as some parameter, and consider adding PoissionSampling Will have to update:
|
…plingParameters (no processdata) and ReadPSUSamplingParameters (no processdata). This change breaks some pre-release projects (v. v1.3-9006). (#127)
In current pre-release of RstoxFDA (1.30-9006), PSU design variables are treated as resource files, although they are not re-usable between projects. They are specific to each execution of the sampling program for a specific fishery. They should probably be treated as input files, similar to how biological records and landing data is provided.
The text was updated successfully, but these errors were encountered: