Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure PSU design variables as input files #127

Open
edvinf opened this issue Sep 16, 2024 · 4 comments · Fixed by #152
Open

restructure PSU design variables as input files #127

edvinf opened this issue Sep 16, 2024 · 4 comments · Fixed by #152
Assignees
Labels
analytical issues for new analytical estimation workflow bug Something isn't working release1.6 Issues that must be solved before release of 1.6 unstableRepo proposed solution to issue is in the develop branch and the unstable repository

Comments

@edvinf
Copy link
Contributor

edvinf commented Sep 16, 2024

In current pre-release of RstoxFDA (1.30-9006), PSU design variables are treated as resource files, although they are not re-usable between projects. They are specific to each execution of the sampling program for a specific fishery. They should probably be treated as input files, similar to how biological records and landing data is provided.

@edvinf edvinf added the bug Something isn't working label Sep 16, 2024
@edvinf edvinf self-assigned this Sep 16, 2024
@edvinf
Copy link
Contributor Author

edvinf commented Sep 20, 2024

Make sure that some guard is added to ensure that users are not mistakenly using old files when copying projects from previous years. Perhaps make year explicit as a stratification column in data preparation.

@edvinf
Copy link
Contributor Author

edvinf commented Sep 23, 2024

These are sampling parameters for data recorded in biotic files. So one natural option would be to simply store them in the existing directory "biotic". Another natural option would be to store them in a new directory, called "design".

@edvinf
Copy link
Contributor Author

edvinf commented Oct 21, 2024

Discussion with AJH and EJ on Oct 21 reaffirmed that we want this as input data, rather than resource files. We decided on the option og storing sampling parameters for biotic data in the biotic data file. No changes are necessary for any other StoX packages. Rework PSU sampling parameters as input data, and not process data. Make the convention about where to locate files clear. Put that path as an example in the function documentation reading them in, and give explicit instructions in vignette.

@edvinf edvinf added the analytical issues for new analytical estimation workflow label Oct 24, 2024
@edvinf
Copy link
Contributor Author

edvinf commented Dec 22, 2024

implement ReadPSUSamplingParameters: as DefinePSUSamplingParameters with DefinitionMethod 'resourceFile', but without processdata options

implement ComputePSUSamplingParameters: as DefinePSUSamplingParameters with DefinitionMethod 'AdHocStoxBiotic', but without processdata options. Keep DefinitionMethod as some parameter, and consider adding PoissionSampling

Will have to update:

  • examples on gitlab
  • vignette
  • RstoxDocumentation project and vignette

@edvinf edvinf added the release2.0 Issues that must be solved before release of 2.0 label Dec 23, 2024
edvinf pushed a commit that referenced this issue Dec 23, 2024
…plingParameters (no processdata) and ReadPSUSamplingParameters (no processdata). This change breaks some pre-release projects (v. v1.3-9006). (#127)
@edvinf edvinf linked a pull request Dec 23, 2024 that will close this issue
@edvinf edvinf added release1.6 Issues that must be solved before release of 1.6 and removed release2.0 Issues that must be solved before release of 2.0 labels Dec 27, 2024
@edvinf edvinf added the unstableRepo proposed solution to issue is in the develop branch and the unstable repository label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analytical issues for new analytical estimation workflow bug Something isn't working release1.6 Issues that must be solved before release of 1.6 unstableRepo proposed solution to issue is in the develop branch and the unstable repository
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant