Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VanillaModelEncoder#emitItemQuads does not respect Forge/NeoForge model extensions #186

Open
PepperCode1 opened this issue Jan 5, 2025 · 0 comments

Comments

@PepperCode1
Copy link
Contributor

NeoForge patches the ItemRenderer to respect IBakedModelExtension#getRenderPasses(ItemStack, boolean) and IBakedModelExtension#getRenderTypes(ItemStack, boolean): https://github.com/neoforged/NeoForge/blob/1.21.1/patches/net/minecraft/client/renderer/entity/ItemRenderer.java.patch#L26-L27.

Neither of these methods are ever called in either Forgified FRAPI or Forgified Indigo, which leads to severe issues like crashes and missing visuals. Calling them in VanillaModelEncoder#emitItemQuads would be the best solution, but would need additional work as FRAPI does not accept RenderTypes directly; this method would need to be moved to Forgified Indigo so it can provide the RenderTypes directly. Inspection of quads with a non-standard RenderType could result in BlendMode.DEFAULT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant