Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that inner rotor can reduce down to simpler geometry #93

Open
elsevers opened this issue Apr 8, 2019 · 3 comments
Open

Verify that inner rotor can reduce down to simpler geometry #93

elsevers opened this issue Apr 8, 2019 · 3 comments
Assignees
Labels
architecture Defining and implementing system architecture. enhancement New feature or request. question Further information is requested.
Milestone

Comments

@elsevers
Copy link
Contributor

elsevers commented Apr 8, 2019

Please verify that the features added in PR #34 do not create duplicate lines when the parameters indicate that aspects of the geometry are not present. For example, consider the following edge cases:

  • when the iron tooth height is such that the iron poles vanish between magnet segments
  • when only one magnet segment is present
  • when the iron tooth span between magnets is zero
  • when the intrapolar iron tooth span is zero (iron tooth between poles)

Further:

  • Identify all corner conditions that must be tested to insure valid geometry (i.e., make sure that a_rm can never be larger than 180 degrees)
  • Implement error checking within the crossSect class
  • Create unit tests each case and place in the tests folder.
@elsevers elsevers added architecture Defining and implementing system architecture. enhancement New feature or request. question Further information is requested. labels Apr 8, 2019
@elsevers elsevers added this to the Tasks for 2019-04-08 milestone Apr 8, 2019
@Nick-Hemenway
Copy link
Collaborator

Check edge case of R_ri going to zero. It should become a solid rotor.

@ngadiyar93
Copy link
Member

ngadiyar93 commented Apr 29, 2019

Verified that R_ri = 0 does lead to a solid rotor and implemented following checks to ensure valid geometry..

  1. alpha_rs (segment span) < alpha_rm (pole span) for s (no. of segments)>1
  2. d_rs = 0 if s=1
  3. d_rs > 0 if s>1
    Working on identifying and implementing tests for rest of the corner conditions.

@npetersen2
Copy link
Contributor

@ngadiyar93 have you added some tests for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Defining and implementing system architecture. enhancement New feature or request. question Further information is requested.
Projects
None yet
Development

No branches or pull requests

4 participants