Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry Validity Check #24

Open
Nick-Hemenway opened this issue Feb 23, 2019 · 1 comment
Open

Geometry Validity Check #24

Nick-Hemenway opened this issue Feb 23, 2019 · 1 comment
Labels
architecture Defining and implementing system architecture. enhancement New feature or request.
Milestone

Comments

@Nick-Hemenway
Copy link
Collaborator

I think we should add some sort of check to make sure the geometry entered is actually valid but I'm not sure if we should do this in the backend, or if we should do this on the front end. For example, for the inner rotor PM stator: If there are 8 teeth, the span angle of each tooth could not be 180 degrees. In other words, this would be an invalid geometry.

We could either have the cross section check that it is valid and return an error if not, or we could put checks in place at the optimization level to make sure no invalid geometries are ever inputted.

@Nick-Hemenway Nick-Hemenway added enhancement New feature or request. architecture Defining and implementing system architecture. labels Feb 23, 2019
@elsevers
Copy link
Contributor

I agree that this is needed and I think each cross-section should be responsible for checking that its own geometry is valid. We have already started to do this with validateattributes() ensuring that dimensions are non-negative.

(It may also make sense to do this at the optimization level, but regardless, an individual cross-section should validate that it is valid)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture Defining and implementing system architecture. enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

3 participants