Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to fix MATLAB cross-sections to properly use dimensions #195

Open
4 of 13 tasks
elsevers opened this issue Mar 21, 2021 · 1 comment · Fixed by #199
Open
4 of 13 tasks

Need to fix MATLAB cross-sections to properly use dimensions #195

elsevers opened this issue Mar 21, 2021 · 1 comment · Fixed by #199
Labels
bug Something isn't working.

Comments

@elsevers
Copy link
Contributor

elsevers commented Mar 21, 2021

When MATLAB cross-sects have hard-coded coordinates (i.e. the origin), they are using floats instead of a dimensions class. This should be resolved by having the hard-coded coordinates take on the data-type of one of the dimensions variables.

For example, this is the current implementation and it is incorrect
https://github.com/Severson-Group/eMach/blob/4f746ae99e915300cebe542786a76b7eef7387cc/model_obj/crosssects/hollowCylinder/CrossSectHollowCylinder.m#L22-L25

Instead, one should use

x_out = feval(class(t), 0);
x_in = feval(class(t), 0);

All cross-sections need to be checked and updated:

  • arc @ngadiyar93
  • breadloaf @ngadiyar93
  • hollowCylinder @ngadiyar93
  • hollowRectangle @ngadiyar93
  • innerNotchedRectangle
  • inner_rotor_stator
  • linearMotorStator
  • notchedRectangle
  • outerRotor
  • outerRotorStator
  • parallelogram
  • solidRectangle
  • trapezoid
@elsevers elsevers added the bug Something isn't working. label Mar 21, 2021
@ngadiyar93 ngadiyar93 linked a pull request Mar 24, 2021 that will close this issue
@ngadiyar93
Copy link
Member

Checked arc, breadloaf, hollowCylinder, and hollowRectangle.

arc: No hard coded coordinates.
breadloaf: Fixed in PR #199
hollowCylinder: Fixed in PR #199
hollowRectangle: Fixed in PR #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants