You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When MATLAB cross-sects have hard-coded coordinates (i.e. the origin), they are using floats instead of a dimensions class. This should be resolved by having the hard-coded coordinates take on the data-type of one of the dimensions variables.
When MATLAB cross-sects have hard-coded coordinates (i.e. the origin), they are using floats instead of a dimensions class. This should be resolved by having the hard-coded coordinates take on the data-type of one of the dimensions variables.
For example, this is the current implementation and it is incorrect
https://github.com/Severson-Group/eMach/blob/4f746ae99e915300cebe542786a76b7eef7387cc/model_obj/crosssects/hollowCylinder/CrossSectHollowCylinder.m#L22-L25
Instead, one should use
All cross-sections need to be checked and updated:
arc
@ngadiyar93breadloaf
@ngadiyar93hollowCylinder
@ngadiyar93hollowRectangle
@ngadiyar93innerNotchedRectangle
inner_rotor_stator
linearMotorStator
notchedRectangle
outerRotor
outerRotorStator
parallelogram
solidRectangle
trapezoid
The text was updated successfully, but these errors were encountered: