Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to ASE 3.23 #48

Open
1 of 13 tasks
alchem0x2A opened this issue Sep 19, 2024 · 0 comments
Open
1 of 13 tasks

Migration to ASE 3.23 #48

alchem0x2A opened this issue Sep 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@alchem0x2A
Copy link
Collaborator

alchem0x2A commented Sep 19, 2024

ASE 3.23 introduces tons of improvements over the 3.22 style, and many of them actually benefits SPARC-X-API as well. This issue summarized the milestones for full migration to the new ASE style.

Release plan:

  • v1.0.x: bug-fix versions that maintain the support for ASE 3.22 while have minimal compatibility with ASE 3.23 (file I/O, socket)
  • v1.1: Migration to ASE 3.23 style. ASE 3.22 support will be deprecated (but still accessible)
    Considering the major release of ASE takes about 1 year, it would be relatively safe to drop the old ASE style in SPARC-X-API v1.2+ release.

Changes to be made

Some minimal support for ASE 3.23 has been added in #47, here're some more until v1.1 release

Global ASE version check

  • Check once for ASE version during import
  • Move legacy code into legacy submodules etc

Module Import

File I/O

  • Fix additional warnings during MD / log parser
  • Add parser for MLFF files
  • Add parser for eigen files

Calculator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant