Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG - Manifest change for enabling semantic date range has no effect on running app with UI5 latest snapshot (=>1.132) #2763

Open
3 tasks
nikmace opened this issue Jan 10, 2025 · 0 comments
Assignees
Labels
bug Something isn't working control-property-editor @sap-ux/control-property-editor

Comments

@nikmace
Copy link
Contributor

nikmace commented Jan 10, 2025

Description

When using the quick action for enabling semantic date range the change does not get applied when the application reloads because the merged manifest is not updated

Steps to Reproduce

Steps to reproduce the behavior:

  1. Start the Adaptation Editor with a V2 application.
  2. Enable/Disable Feature:
  • Enable or disable the Semantic Date Range in the FilterBar.
  1. Save and Observe:
  • Click on Save to trigger a reload.
  • Observe that the changes are not visible in the preview.
  1. Switch UI5 Version to 1.131.0:
  • Substitute the last two lines in your configuration as follows:
  • url: https://ui5.sap.com
  • version: 1.131.0
  1. Repeat Steps 4-5:
  • Perform steps 4 and 5 again.
  • Notice that the changes are now visible in the preview.

While performing the above steps, check the adaptation-editor.html.inner.html response in the network tab. All relevant changes (descriptor changes) should be merged into the manifest. You can confirm this by inspecting the response of the adaptation-editor.html.inner.html searching for $sap.ui.fl.change.

Changes between UI5 Version 1.131.0 and 1.133.0

  • UI5 Version 1.131.0:

    • Each reload triggers a new request to the backend.
    • The changes are reflected correctly in the adaptation-editor.html.inner.html response.
  • UI5 Version 1.133.0:

    • Only the initial start of the Adaptation Editor triggers a backend request.
    • Subsequent reloads do not trigger a request, and the response appears cached.

Expected results

Merged manifest is synced

Actual results

Manifest

Screenshots

If applicable, add screenshots to help explain the problem.

Version/Components/Environment

Add any other context about the problem here
OS:

  • Mac OS
  • Windows
  • Other

Root Cause Analysis

Problem

{describe the problem}

Fix

{describe the fix}

Why was it missed

{Some explanation why this issue might have been missed during normal development/testing cycle}

How can we avoid this

{if we don’t want to see this type of issues anymore what we should do to prevent}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working control-property-editor @sap-ux/control-property-editor
Projects
None yet
Development

No branches or pull requests

1 participant