Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sktime - registry - adding new models #128

Open
RobotPsychologist opened this issue Nov 8, 2024 · 1 comment
Open

sktime - registry - adding new models #128

RobotPsychologist opened this issue Nov 8, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request sktimedev Work for the team developing our desired changes to sktime

Comments

@RobotPsychologist
Copy link
Owner

Adding New Models

Walkthrough

A walkthrough example of how to add new models to the registry:

  • Developer Guide: https://www.sktime.net/en/latest/developer_guide/add_estimators.html
  • Notebook by Felipe: https://github.com/sktime/sktime-tutorial-euroscipy2024/blob/main/notebooks/04_customization.ipynb
  • Generalities: for adding to sktime, open a new issue ("feature request", "implementing estimator" or "interfacing estimator" if in other library)
  • Adding a new concrete class -> automatically adds to registry
  • "howto" = "fill out extension template", see developer guide
  • If the class is maintained in a different package, use "placeholder record" pattern, see HierarchicalProphet
  • CAVEAT with detectors: extension template was recently updated to follow the new API, recommend to stay in conversation with owner of API issue to ensure extension template is also consistent with any changes
    • unified API changes usually require changes to
      • base class public and private API
      • test class
      • extension template (documents the private API)
      • example notebook (documents the public API)
    • and require changes to be consistent to avoid trouble
  • Felipe recommendation: understand the tags!

Algorithms List

  • [ ]
@RobotPsychologist RobotPsychologist added the sktimedev Work for the team developing our desired changes to sktime label Nov 8, 2024
@RobotPsychologist RobotPsychologist self-assigned this Nov 8, 2024
@RobotPsychologist RobotPsychologist added the enhancement New feature or request label Nov 8, 2024
@gavinkatz001
Copy link
Contributor

commenting to get assigned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sktimedev Work for the team developing our desired changes to sktime
Projects
None yet
Development

No branches or pull requests

2 participants