Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out Favonia Namespace code into library #488

Open
jonsterling opened this issue Jan 10, 2020 · 3 comments
Open

Factor out Favonia Namespace code into library #488

jonsterling opened this issue Jan 10, 2020 · 3 comments
Assignees

Comments

@jonsterling
Copy link
Collaborator

For now, just a local library in this repository.

@ivoysey
Copy link
Contributor

ivoysey commented Jan 10, 2020

Sounds good. For updating the version, I defaulted to making a fork on my own account and doing a PR from that without actually asking if that's the right thing to do. Is that a reasonable process for you? @cangiuli suggested that it might be better if I made a branch on this repo and a PR from that to master, so that it'd be easier for other folks to work on what I'm working on.

@jonsterling
Copy link
Collaborator Author

Good question! We usually work on branches in the main repo rather than forks.

@ivoysey
Copy link
Contributor

ivoysey commented Jan 10, 2020

Gotcha; I'll use that style from now on, then.

@ivoysey ivoysey self-assigned this Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants