Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Pagination widget #84

Open
ldjebran opened this issue Feb 25, 2019 · 2 comments
Open

Implement Pagination widget #84

ldjebran opened this issue Feb 25, 2019 · 2 comments

Comments

@ldjebran
Copy link

https://www.patternfly.org/pattern-library/navigation/pagination/

This pagination widget is more and more needed for our airgun framework, we are creating a solution of this widget in airgun SatelliteQE/airgun#292 but a more general solution should be implemented here.

@digitronik
Copy link
Member

@ldjebran as per me; In WT we are trying to address widgets not a combination of widgets (views). Yup paginator is part of the table as per pfy widget you pointed but we can add a view in a local project (airgun already implemented 👍 ) or wt.pfy; which can combine table and paginator.

In this view, you can add more facilities like surf_page for the pertular entity in the table and return the object, etc... I would give the first choice to local project widget collection, not in wt.pfy. It's my personal view.

@mshriver
Copy link
Collaborator

https://github.com/RedHatQE/widgetastic.patternfly4/blob/master/src/widgetastic_patternfly4/pagination.py#L18

This has been implemented within wt.pf4, and there is likely a large overlap between the BasePagination class for pf4 and the pf3 pagination implementation.

If a class is implemented here, it should be utilized in wt.pf4 for BasePagination to avoid repeating the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants