Use <icon> over favicon as feed icon

[vwkd]

Problem

It seems the favicon of a domain is given precedence over a possible <icon> element in an Atom feed.

This breaks feed generator websites that allow users to create custom feeds with custom icons, since every user feed gets the same favicon instead of their custom icon.

For example, a kill-the-newsletter feed.

I didn't test it with other feed types like RSS or JSON.

Steps To Reproduce

Add feed https://kill-the-newsletter.com/feeds/iu8547vjdyb06za1lb1u.xml to NetNewsWire.

The feed's XML

<?xml version="1.0" encoding="utf-8"?>
    <feed xmlns="http://www.w3.org/2005/Atom">
      <id>urn:kill-the-newsletter:iu8547vjdyb06za1lb1u</id>
      <link
        rel="self"
        href="https://kill-the-newsletter.com/feeds/iu8547vjdyb06za1lb1u.xml"
      />
      <link
        rel="hub"
        href="https://kill-the-newsletter.com/feeds/iu8547vjdyb06za1lb1u/websub"
      />
      <icon
            >https://www.google.com/s2/favicons?domain=https://netnewswire.com&amp;sz=32</icon
          >
      <updated
        >2000-01-01T00:00:00.000Z</updated
      >
      <title>Test</title>
      
    </feed>

Expected Result

The feed icon is the URL in the <icon> element.

Actual Result

The feed icon is the /favicon.ico.

[brentsimmons]

The problem with icons specified in feeds is that they are often not square — and favicons are (pretty much always) square. The app really wants square icons!

(We will of course look into this in the future. There are things we can do. The above is just to explain why we went with favicons over icons specified in feeds in the first place.)