From 11e8665b41c1b547778e37c5faa3f7ddeb2ee9c4 Mon Sep 17 00:00:00 2001 From: bubblobill <45483160+bubblobill@users.noreply.github.com> Date: Mon, 2 Sep 2024 15:00:40 +0800 Subject: [PATCH] Added check in ButtonGroup drag event drop to return if no change in group. Before checking for permissions, if there is no change in button group it returns false. --- .../client/ui/macrobuttons/buttongroups/ButtonGroup.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/main/java/net/rptools/maptool/client/ui/macrobuttons/buttongroups/ButtonGroup.java b/src/main/java/net/rptools/maptool/client/ui/macrobuttons/buttongroups/ButtonGroup.java index bb1622a70a..713ac6626b 100644 --- a/src/main/java/net/rptools/maptool/client/ui/macrobuttons/buttongroups/ButtonGroup.java +++ b/src/main/java/net/rptools/maptool/client/ui/macrobuttons/buttongroups/ButtonGroup.java @@ -128,7 +128,10 @@ public void drop(DropTargetDropEvent event) { MacroButtonProperties oldMacroProps = new MacroButtonProperties(tempProperties); // stops players from moving macros into/from the Campaign/GM panels - if (!MapTool.getPlayer().isGM() + // debounce first, ignore moves that change nothing + if (tempProperties.getGroup().equals(getMacroGroup())) { + event.dropComplete(false); + } else if (!MapTool.getPlayer().isGM() && (panelClass.equals("CampaignPanel") || panelClass.equals("GmPanel") || (data.panelClass.equals("CampaignPanel")