From 692e225657dbf72105898023bb270b39d18e9b2a Mon Sep 17 00:00:00 2001 From: Charles Hofer Date: Thu, 31 Oct 2024 10:20:23 -0500 Subject: [PATCH 1/7] Add workflow for nightly pull from upstream --- .../workflows/rocm-nightly-upstream-sync.yml | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 .github/workflows/rocm-nightly-upstream-sync.yml diff --git a/.github/workflows/rocm-nightly-upstream-sync.yml b/.github/workflows/rocm-nightly-upstream-sync.yml new file mode 100644 index 000000000000..880ea232d307 --- /dev/null +++ b/.github/workflows/rocm-nightly-upstream-sync.yml @@ -0,0 +1,18 @@ +# Pulls the latest changes from upstream into main and opens a PR to merge +# them into rocm-main. + +name: ROCm Nightly Upstream Sync +on: + schedule: + - cron: '0 6 * * *' +jobs: + sync-main: + runs-on: ubuntu-latest + steps: + - run: gh repo sync rocm/jax -b main + env: + GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} + open-sync-pr: + runs-on: ubuntu-latest + steps: + - run: gh pr create --repo rocm/jax --head main --base rocm-main --title "CI: $(date +%x) upstream sync" --body "Daily sync with upstream" From 1c877f5a7eecda5bdc834b4f9304946611524425 Mon Sep 17 00:00:00 2001 From: Charles Hofer Date: Thu, 31 Oct 2024 10:29:36 -0500 Subject: [PATCH 2/7] Only run on weekdays --- .github/workflows/rocm-nightly-upstream-sync.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/rocm-nightly-upstream-sync.yml b/.github/workflows/rocm-nightly-upstream-sync.yml index 880ea232d307..ba81edac5bc9 100644 --- a/.github/workflows/rocm-nightly-upstream-sync.yml +++ b/.github/workflows/rocm-nightly-upstream-sync.yml @@ -4,7 +4,7 @@ name: ROCm Nightly Upstream Sync on: schedule: - - cron: '0 6 * * *' + - cron: '0 6 * * 1-5' jobs: sync-main: runs-on: ubuntu-latest From 3361fca5b8300d17a007decc0139b0d384b8d9cd Mon Sep 17 00:00:00 2001 From: Charles Hofer Date: Thu, 31 Oct 2024 10:49:29 -0500 Subject: [PATCH 3/7] Fix yaml checker --- .github/workflows/rocm-nightly-upstream-sync.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/rocm-nightly-upstream-sync.yml b/.github/workflows/rocm-nightly-upstream-sync.yml index ba81edac5bc9..dcfbc01d1db5 100644 --- a/.github/workflows/rocm-nightly-upstream-sync.yml +++ b/.github/workflows/rocm-nightly-upstream-sync.yml @@ -15,4 +15,5 @@ jobs: open-sync-pr: runs-on: ubuntu-latest steps: - - run: gh pr create --repo rocm/jax --head main --base rocm-main --title "CI: $(date +%x) upstream sync" --body "Daily sync with upstream" + - run: | + gh pr create --repo $GITHUB_REPOSITORY --head main --base rocm-main --title "CI: $(date +%x) upstream sync" --body "Daily sync with upstream" From 1f66c29d0585fe64f60683fb9929b8a2f9abe7f5 Mon Sep 17 00:00:00 2001 From: Charles Hofer Date: Thu, 31 Oct 2024 11:39:28 -0500 Subject: [PATCH 4/7] Set runners for ROCM --- .github/workflows/ci-build.yaml | 2 +- .github/workflows/upstream-nightly.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci-build.yaml b/.github/workflows/ci-build.yaml index 581fb858732c..7805e3206fcd 100644 --- a/.github/workflows/ci-build.yaml +++ b/.github/workflows/ci-build.yaml @@ -38,7 +38,7 @@ jobs: build: name: "build ${{ matrix.name-prefix }} (py ${{ matrix.python-version }} on ubuntu-20.04, x64=${{ matrix.enable-x64}})" - runs-on: linux-x86-n2-32 + runs-on: ROCM-Ubuntu container: image: index.docker.io/library/ubuntu@sha256:6d8d9799fe6ab3221965efac00b4c34a2bcc102c086a58dff9e19a08b913c7ef # ratchet:ubuntu:20.04 timeout-minutes: 60 diff --git a/.github/workflows/upstream-nightly.yml b/.github/workflows/upstream-nightly.yml index 04df278019a5..ada9b4e5825f 100644 --- a/.github/workflows/upstream-nightly.yml +++ b/.github/workflows/upstream-nightly.yml @@ -22,7 +22,7 @@ on: jobs: upstream-dev: - runs-on: ubuntu-20.04-16core + runs-on: ROCM-Ubuntu permissions: contents: read checks: write # for upload-artifact From 7a15265542d850fd7859bba7619bcae6a7407bd5 Mon Sep 17 00:00:00 2001 From: charleshofer Date: Thu, 31 Oct 2024 15:43:35 -0500 Subject: [PATCH 5/7] Allow devs to kick off sync job manually (#119) --- .github/workflows/rocm-nightly-upstream-sync.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/rocm-nightly-upstream-sync.yml b/.github/workflows/rocm-nightly-upstream-sync.yml index dcfbc01d1db5..98c958c3daa0 100644 --- a/.github/workflows/rocm-nightly-upstream-sync.yml +++ b/.github/workflows/rocm-nightly-upstream-sync.yml @@ -3,6 +3,7 @@ name: ROCm Nightly Upstream Sync on: + workflow_dispatch: schedule: - cron: '0 6 * * 1-5' jobs: From 14139a3f4a01c1d6b7d31baf34c05a2a3f2cc4ef Mon Sep 17 00:00:00 2001 From: Charles Hofer Date: Fri, 1 Nov 2024 10:05:43 -0500 Subject: [PATCH 6/7] Unpin container in CI build and remove libssl-dev install --- .github/workflows/ci-build.yaml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/ci-build.yaml b/.github/workflows/ci-build.yaml index 7805e3206fcd..6ac7a138d7da 100644 --- a/.github/workflows/ci-build.yaml +++ b/.github/workflows/ci-build.yaml @@ -39,8 +39,6 @@ jobs: build: name: "build ${{ matrix.name-prefix }} (py ${{ matrix.python-version }} on ubuntu-20.04, x64=${{ matrix.enable-x64}})" runs-on: ROCM-Ubuntu - container: - image: index.docker.io/library/ubuntu@sha256:6d8d9799fe6ab3221965efac00b4c34a2bcc102c086a58dff9e19a08b913c7ef # ratchet:ubuntu:20.04 timeout-minutes: 60 strategy: matrix: @@ -58,10 +56,6 @@ jobs: num_generated_cases: 1 steps: - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 - - name: Image Setup - run: | - apt update - apt install -y libssl-dev - name: Set up Python ${{ matrix.python-version }} uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0 with: From 700f3bdccc720e5381dfb242927ddc1e50429a6c Mon Sep 17 00:00:00 2001 From: charleshofer Date: Mon, 4 Nov 2024 17:10:03 -0600 Subject: [PATCH 7/7] Rename the CI flow to 'ROCm CI' and only run it on PRs to rocm-main (#126) * Rename the CI flow to 'ROCm CI' and only run it on PRs to the rocm-main branch * Change name to 'ROCm CPU CI' --- .github/workflows/ci-build.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci-build.yaml b/.github/workflows/ci-build.yaml index 6ac7a138d7da..2183aaf8948d 100644 --- a/.github/workflows/ci-build.yaml +++ b/.github/workflows/ci-build.yaml @@ -1,4 +1,4 @@ -name: CI +name: ROCm CPU CI # We test all supported Python versions as follows: # - 3.10 : Documentation build @@ -11,10 +11,10 @@ on: # but only for the main branch push: branches: - - main + - rocm-main pull_request: branches: - - main + - rocm-main permissions: contents: read # to fetch code