Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: shared libhsakmt #263

Open
trixirt opened this issue Dec 7, 2024 · 4 comments
Open

[Issue]: shared libhsakmt #263

trixirt opened this issue Dec 7, 2024 · 4 comments

Comments

@trixirt
Copy link
Contributor

trixirt commented Dec 7, 2024

Problem Description

Some issues with the transition of hsakmt in creating a shared library on Fedora

https://github.com/ROCm/ROCR-Runtime/blob/amd-staging/libhsakmt/CMakeLists.txt#L140
Hardcodes 'Static'

https://github.com/ROCm/ROCR-Runtime/blob/amd-staging/libhsakmt/src/libhsakmt.ver
Is missing
hsaKmtCreateQueueExt;
hsaKmtRegisterGraphicsHandleToNodesExt;

Operating System

Fedora Rawhide

CPU

ALL

GPU

ALL

ROCm Version

ROCm 6.3.0

ROCm Component

No response

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

@ppanchad-amd
Copy link

Hi @trixirt. Internal ticket has been created to investigate your issue. Thanks!

@Mystro256
Copy link
Contributor

@trixirt starting with 6.3, hsakmt is expected not to be interfaced publicly anymore. It's meant to be a static lib within rocr now. Perhaps the cmake logic needs to be fixed a bit, but the intention is for all public hsakmt interfaces to go through libhsa-runtime64 now.

@trixirt
Copy link
Contributor Author

trixirt commented Dec 9, 2024

A separate delivered static library is a flaw, distros are very strict about no static libraries.

@Mystro256
Copy link
Contributor

A separate delivered static library is a flaw, distros are very strict about no static libraries.

Yeah I was speaking with @kentrussell , I suspect this is a bug.
These lines should be dropped to be consistent with the design:
https://github.com/ROCm/ROCR-Runtime/blob/rocm-6.3.0/libhsakmt/CMakeLists.txt#L194-L200

Need to confirm, but I was told libhsakmt was supposed to be dropped for 6.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants