Build fails after seal blinding upgrade to 64 bit

[dr-orlovsky]

We have an RGB node build failing after LNP/BP Core library adopting 64-bit blinding factors for seal definitions after LNP-BP/rust-lnpbp#52 acceptance

[Goosie]

Let me know when I can help with testing or whatever.

[rajarshimaitra]

Hi @Goosie thanks for the report. Posted a fix in rust-lnpbp LNP-BP/rust-lnpbp#58.

You can try changing the lnp-bp dependency to my branch https://github.com/rajarshimaitra/rust-lnpbp/tree/build-fix-28/07
And see if the build passes. Hopefully, this should do the fix.

[Goosie]

Yess thanks, No errors after cargo build --release in this directory now. Thanks!, Up to the next steps :-)
I assume I have to change this path in Cargo.toml

[Goosie]

I react to early. I removed the rgb-node directory. Cloned the repository from rgb-node again and changed the path in Cargo.toml Under section [dependencies.lnpbo] I changed the path
git = "https://github.com/lnp-bp/rust-lnpbp" into git = "https://github.com/rajarshimaitra/rust-lnpbp" After running cargo build --release I get the same error as started:
error[E0308]: mismatched types
--> /home/alice/.cargo/git/checkouts/rust-lnpbp-a0ee553585762f76/2f6fee7/src/rgb/contract/amount.rs:92:48
|
92 | match (&self.commitment.0).partial_cmp(&other.commitment.0[..]) {
| ^^^^^^^^^^^^^^^^^^^^^^^ expected array [u8; 33], found slice [u8]
|
= note: expected reference &[u8; 33]
found reference &[u8]

Do I have to change the path somewhere else maybe?

[rajarshimaitra]

git = "https://github.com/lnp-bp/rust-lnpbp" into git = "https://github.com/rajarshimaitra/rust-lnpbp" After running cargo build --release I get the same error as started:

Right, just one more change. Add the branch name too like this in Cargo.toml

[dependencies.lnpbp]
git = "https://github.com/rajarshimaitra/rust-lnpbp"
branch = "build-fix-28/07"
features = ["all"]

[Goosie]

Yess. It's working now :-)

[dr-orlovsky]

I actually did a fix in a master commit two days before, but it appears that I have not added the required changes to it with git add :) So I have merged @rajarshimaitra PR now and you can link to the master

[dr-orlovsky]

@rajarshimaitra can you pls work on fixing the issue with u32->u64 here in RGB node after LNP/BP change? The discussion here is actually misleading, since it's about an unrelated issue (namely fixed with some other your PR)...

[rajarshimaitra]

Yes working on it.