Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peak correlation matrix: Likely to go out of bounds for large peak tables #95

Open
hechth opened this issue Feb 16, 2022 · 3 comments
Open
Assignees
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@hechth
Copy link
Member

hechth commented Feb 16, 2022

For large peak tables, the computation of the correlation matrix might produce very large outputs - this is the same problem as in the RAMClustR package.

Maybe it would make sense to find some common sparse correlation matrix implementation?

@hechth hechth added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels Feb 16, 2022
@hechth
Copy link
Member Author

hechth commented Jun 29, 2022

@xtrojak now since this is fixed in RAMClustR, do you think this could also be done in xMSannotator?

@xtrojak
Copy link

xtrojak commented Jun 29, 2022

@hechth just to clarify, we are just talking about memory consumption optimisation, otherwise it works fine in xMSannotator? Or was there any case when a run failed for insufficient memory?

@hechth
Copy link
Member Author

hechth commented Jul 5, 2022

No - this is just a preliminary "issue" on GitHub since I expect to run into similar problems with xMSannotator as with RAMClustR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants