From 293fa2bd473cb2778d35c11584c6276143aa0ab7 Mon Sep 17 00:00:00 2001 From: lepapareil Date: Fri, 10 Jan 2025 14:09:34 +0100 Subject: [PATCH] Revert "Set persist-credentials to false on checkout action" --- .github/workflows/accept-pull-request.yml | 1 - .github/workflows/auto-close-inactive-pr.yml | 2 -- .github/workflows/check.yml | 1 - .github/workflows/coverage.yml | 2 -- .github/workflows/extra-package.yml | 3 --- .github/workflows/package.yml | 12 ------------ .github/workflows/release.yml | 6 ------ .github/workflows/test.yml | 13 +------------ .github/workflows/update-actions.yml | 1 - .github/workflows/update-branch-version.yml | 1 - .github/workflows/update-crates.yml | 1 - 11 files changed, 1 insertion(+), 42 deletions(-) diff --git a/.github/workflows/accept-pull-request.yml b/.github/workflows/accept-pull-request.yml index 3dbae06582f..a7148b1ef60 100644 --- a/.github/workflows/accept-pull-request.yml +++ b/.github/workflows/accept-pull-request.yml @@ -69,7 +69,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ env.BASE_REF }} token: ${{ secrets.HURL_BOT_TOKEN }} fetch-depth: 0 diff --git a/.github/workflows/auto-close-inactive-pr.yml b/.github/workflows/auto-close-inactive-pr.yml index c9d256d1b7b..a42a4b2fc61 100644 --- a/.github/workflows/auto-close-inactive-pr.yml +++ b/.github/workflows/auto-close-inactive-pr.yml @@ -18,8 +18,6 @@ jobs: steps: - name: Checkout repository uses: actions/checkout@v4.2.2 - with: - persist-credentials: false - name: Auto close inactive PR run: .github/workflows/bin/auto-close-inactive-pr.sh --github-project-path "${REPO}" --github-token "${GITHUB_TOKEN}" --max-days-of-inactivity 15 diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 022d48a9019..3fdff82d601 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -22,7 +22,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Shellcheck diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index 652b9771d80..90a89456b38 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -17,8 +17,6 @@ jobs: steps: - name: Checkout repository uses: actions/checkout@v4.2.2 - with: - persist-credentials: false - name: Install Prerequisites run: bin/install_prerequisites_ubuntu.sh diff --git a/.github/workflows/extra-package.yml b/.github/workflows/extra-package.yml index 9b52f7cee1c..84a0b2cca02 100644 --- a/.github/workflows/extra-package.yml +++ b/.github/workflows/extra-package.yml @@ -29,7 +29,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false fetch-depth: 1 ref: ${{ github.event.inputs.set-release-version }} - name: Check if branch is a published release @@ -53,7 +52,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false fetch-depth: 1 ref: ${{ github.event.inputs.set-release-version }} - name: Push to chocolatey @@ -71,7 +69,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false fetch-depth: 1 ref: ${{ github.event.inputs.set-release-version }} - name: Push to winget diff --git a/.github/workflows/package.yml b/.github/workflows/package.yml index 55cac8fcbdf..33d89a41613 100644 --- a/.github/workflows/package.yml +++ b/.github/workflows/package.yml @@ -21,7 +21,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Install prerequisites run: bin/install_prerequisites_ubuntu.sh @@ -65,7 +64,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Set up QEMU uses: docker/setup-qemu-action@v3.3.0 @@ -115,7 +113,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Retrieve release-generic-linux-x64-artifacts uses: actions/download-artifact@v4.1.8 @@ -169,7 +166,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Retrieve release-generic-linux-x64-artifacts uses: actions/download-artifact@v4.1.8 @@ -221,7 +217,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Retrieve release-generic-linux-x64-artifacts uses: actions/download-artifact@v4.1.8 @@ -273,7 +268,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Retrieve release-generic-linux-x64-artifacts uses: actions/download-artifact@v4.1.8 @@ -327,7 +321,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Set up Docker Buildx uses: docker/setup-buildx-action@v3.8.0 @@ -399,7 +392,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Install Prerequisites run: bin/install_prerequisites_ubuntu.sh @@ -451,7 +443,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Install Prerequisites run: | @@ -501,7 +492,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Install Prerequisites run: | @@ -557,7 +547,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Install Rust run: | @@ -617,7 +606,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - uses: actions/download-artifact@v4.1.8 with: diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 83710c7f31e..332d0033e3e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -54,8 +54,6 @@ jobs: steps: - name: Checkout repository uses: actions/checkout@v4.2.2 - with: - persist-credentials: false - name: Check release pull request existence id: check-release-pull-request-existence @@ -172,8 +170,6 @@ jobs: - name: Checkout repository if: github.ref_name == 'master' uses: actions/checkout@v4.2.2 - with: - persist-credentials: false - name: Create release branch if: github.ref_name == 'master' @@ -191,7 +187,6 @@ jobs: - name: Checkout new release branch uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ needs.set-context.outputs.release_branch }} - name: Check CHANGELOG @@ -298,7 +293,6 @@ jobs: - name: Checkout new release branch uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ needs.set-context.outputs.release_branch }} - name: Init git bot context diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 274e653936b..d0d8886329c 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -21,7 +21,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Install Prerequisites run: bin/install_prerequisites_ubuntu.sh @@ -55,7 +54,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Install Rust run: bin/install_rust.sh @@ -77,7 +75,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Install Prerequisites run: bin/install_prerequisites_ubuntu.sh @@ -122,7 +119,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Install Prerequisites run: bin/install_prerequisites_ubuntu.sh @@ -164,7 +160,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Build, Test units and Integration tests uses: addnab/docker-run-action@v3 @@ -206,7 +201,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Build, Test units and Integration tests uses: addnab/docker-run-action@v3 @@ -255,7 +249,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Build, Test units and Integration tests uses: addnab/docker-run-action@v3 @@ -306,7 +299,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Install Prerequisites run: | @@ -355,7 +347,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Install Prerequisites run: | @@ -407,7 +398,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Install Rust run: | @@ -449,8 +439,7 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false - ref: ${{ inputs.branch }} + ref: ${{ inputs.branch }} - name: Setup wsl Ubuntu uses: Vampire/setup-wsl@v4.1.0 with: diff --git a/.github/workflows/update-actions.yml b/.github/workflows/update-actions.yml index 487a814c964..7c60ea6dfe4 100644 --- a/.github/workflows/update-actions.yml +++ b/.github/workflows/update-actions.yml @@ -20,7 +20,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: master token: ${{ secrets.HURL_BOT_TOKEN }} diff --git a/.github/workflows/update-branch-version.yml b/.github/workflows/update-branch-version.yml index 6255d4bf2a9..1f39a30c8fd 100644 --- a/.github/workflows/update-branch-version.yml +++ b/.github/workflows/update-branch-version.yml @@ -49,7 +49,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: ${{ inputs.branch }} - name: Init bot branch name diff --git a/.github/workflows/update-crates.yml b/.github/workflows/update-crates.yml index 92478f3bcd3..40af2332a86 100644 --- a/.github/workflows/update-crates.yml +++ b/.github/workflows/update-crates.yml @@ -20,7 +20,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v4.2.2 with: - persist-credentials: false ref: master - name: Crates update