Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add pyston element because pyston are a collection #178

Open
Nyan11 opened this issue Jun 15, 2024 · 4 comments
Open

Cannot add pyston element because pyston are a collection #178

Nyan11 opened this issue Jun 15, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Nyan11
Copy link
Collaborator

Nyan11 commented Jun 15, 2024

It's impossible, the root element MUST BE a single element.

Need to change all of the architecture...

@labordep labordep added the enhancement New feature or request label Jul 17, 2024
@labordep
Copy link
Member

Ok, as discuss at ESUG: we will do that.

@labordep
Copy link
Member

@Nyan11 What about this issue?

@Nyan11
Copy link
Collaborator Author

Nyan11 commented Sep 30, 2024

This issue is a huge problem.

Pyramid should only edit 1 root element and not a colleciton of root elements.

Why

  1. Try to add a pyston containing multiple root elements to a new Pyramid project.
  2. Now change the order of one of the element, or delete one of the element.

The pyston in the new project is in uncoherent state, it is no more a pyston because it does not corespond to any of the pyston definition of the system.
Therefor you loose the link between your new Pyramid project and the old Pyston you try to import.

If the pyston root is only one element, you could change the order, add or delete elements, the link between the new project and the pyston can still be there.

Therefor

  • You could edit the old pyston inside the new project and save the changes in the old pyston.
  • You could serialize the old pyston has only a pyston reference and not the entire tree of elements.
  • You could create the different subcomponent of your UI inside multiple Pyston and combining the Pyston together inside a global Pyston.

How to do it

Changing the model will broke all design made with Pyramid.
It is a bad design decision we made at the start of the project.
We have to think about a way to deprecate the old pyston whitout breaking all systems.

@labordep
Copy link
Member

Ok! Thanks, can we think about a good way to depreciate old design?
Il should be nice to rebuild them with the futur new pattern but I think this is an alpha and this is the risk in this phase! However with Stash we can easily recover some code from old design to rebuild manually a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants