Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Would like to be able to access the server status API #47

Open
AndrewSav opened this issue Mar 26, 2021 · 2 comments
Open

Would like to be able to access the server status API #47

AndrewSav opened this issue Mar 26, 2021 · 2 comments
Assignees
@jbristowe
Labels
kind/enhancement New feature or request

Comments

@AndrewSav
Copy link

Is your feature request related to a problem? Please describe.

Wanted to get service status. Was not able to. server_status_service.go does not seem to have any methods, and the likes of apiGet is private so cannot implement myself without re-inventing the wheel.

Describe the solution you'd like
I'd like the api for server status implemented similar to other services.

Describe alternatives you've considered

  • Not use this library and use http client instead
  • Implement the methods myself by copy-pasting code of apiGet and dependent methods to my project
@jbristowe jbristowe self-assigned this Mar 26, 2021
@jbristowe jbristowe added the kind/enhancement New feature or request label Mar 26, 2021
jbristowe added a commit that referenced this issue Mar 27, 2021
@jbristowe
feat: serverStatus and serverStatusService.Get()
d643c35 
Implemented serverStatus type and added Get API to serverStatusSevice. Includes simple test.

Refs #47
@jbristowe jbristowe mentioned this issue Mar 27, 2021
Merged
@AndrewSav
Copy link
Author

@jbristowe thank you very much for your work. Can we also do /api/serverstatus/system-info please?

@jbristowe jbristowe reopened this Mar 30, 2021
@jbristowe
Copy link
Contributor

Reopening this issue for the API endpoint (above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbristowe jbristowe

Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbristowe @AndrewSav