getmodel: decreased accuracy of prob due to untimely conversion from float32 to float64

[FangWeihua]

Issue Description

When computing cdf by using getmodel (compiling option: typedef float OASIS_FLOA), the accuracy of prob may decease, due to untimely conversion from float32 to float64.

Steps to Reproduce

1. In getmodel.cpp (line 49-350), 'prob' is calculated as,

prob += vulnerability[getVulnerabilityIndex(i.first, damage_bin_index)] *
                                         i.second;

The data types of vulnerability[getVulnerabilityIndex(i.first, damage_bin_index)] and i.second are both float32. And the data type of 'prob' is float64. This may lead to slight data accuracy decrease.

2. Accuracy can be improved by converting float32 to float64 first, as follows,

prob + = static_cast<double>(vulnerability[getVulnerabilityIndex(i.first, damage_bin_index)]) *
                static_cast<double>(i.second);

Version / Environment information

ktools v3.12.4
typedef float OASIS_FLOAT