Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Specification] Industry Codes table refactor #196

Closed
4 tasks
johcarter opened this issue Jun 20, 2024 · 1 comment
Closed
4 tasks

[Specification] Industry Codes table refactor #196

johcarter opened this issue Jun 20, 2024 · 1 comment
Assignees
@johcarter
Labels
minor minor release (non-breaking change)

Comments

@johcarter
Copy link
Contributor

Description

  • Removed spaces in scheme names in industry codes table to align with enumerated values in OtherValues tab (eg US SIC --> USSIC)
  • Put all schemes in one long table rather than three separate tables

Reasons for change

Consistency of industry scheme names in specification, and consolidate code lists to make them more machine-readable

Scope of change

Specification

  • Location File
  • Accounts File
  • Reinsurance Scope
  • Reinsurance Info

Impact of change

None
@johcarter johcarter added the minor minor release (non-breaking change) label Jun 20, 2024
@johcarter johcarter self-assigned this Jun 20, 2024
@johcarter johcarter moved this to Under discussion in Open Data Standards Jun 20, 2024
@johcarter johcarter moved this from Under discussion to Agreed and ready in Open Data Standards Jun 20, 2024
@johcarter johcarter moved this from Agreed and ready to In progress in Open Data Standards Jun 20, 2024
@johcarter johcarter moved this from In progress to Agreed and ready in Open Data Standards Jun 26, 2024
@johcarter johcarter moved this to Under discussion in OED 4.0.0 Jun 26, 2024
@johcarter johcarter moved this from Under discussion to Agreed and ready in OED 4.0.0 Jun 26, 2024
@johcarter johcarter moved this from Agreed and ready to In progress in OED 4.0.0 Jun 26, 2024
johcarter added a commit that referenced this issue Jun 26, 2024
@johcarter
#196 added table
d1ed972
@johcarter johcarter moved this from In progress to In review in OED 4.0.0 Jun 27, 2024
@MattDonovan82
Copy link
Contributor

Nothing further to add here. Moving to done.

@MattDonovan82 MattDonovan82 moved this from In review to Agreed and ready in OED 4.0.0 Jul 12, 2024
@MattDonovan82 MattDonovan82 moved this from Agreed and ready to Done in OED 4.0.0 Jul 12, 2024
sambles pushed a commit that referenced this issue Jul 17, 2024
@johcarter @sambles
#196 added table
442f1f2
@johcarter johcarter mentioned this issue Aug 21, 2024
Merged
@johcarter johcarter moved this from Todo to Waiting for Review in Oasis Dev Team Tasks Dec 4, 2024
@github-project-automation github-project-automation bot moved this from Waiting for Review to Done in Oasis Dev Team Tasks Jan 9, 2025
@github-project-automation github-project-automation bot moved this from Agreed and ready to Done in Open Data Standards Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johcarter johcarter

Labels
minor minor release (non-breaking change)
Projects
OED 4.0.0
Status: Done
Oasis Dev Team Tasks
Status: Done
Open Data Standards
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johcarter @MattDonovan82