Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Property] Correct Data Type of SoilType from float to tinyint and valid values from [0,) to [0,1] #195

Closed
3 tasks
johcarter opened this issue Jun 20, 2024 · 1 comment
Assignees
Labels
major major release (breaking change)

Comments

@johcarter
Copy link
Contributor

johcarter commented Jun 20, 2024

Description

SoilType should be a tiny int not a float with valid values [0,1]

Reasons for change

Correcting an accidental change of data type and valid values range introduced in OED v3.2 (was originally a tinyint, [0,1])

Scope of change

  • [ X] Location File
  • Accounts File
  • Reinsurance Scope
  • Reinsurance Info

Impact of change

Although technically a breaking change, it is unlikely that any previous version OED file had a floating point value in this field as the valid values are specified in Other Values tab as 0 or 1.

Data type, default values, are blanks allowed, list valid values

Field Name Data type Default values Valid values
SoilType tinyint 0 [0,1]
@johcarter johcarter added the major major release (breaking change) label Jun 20, 2024
@johcarter johcarter self-assigned this Jun 20, 2024
@johcarter johcarter moved this to Under discussion in Open Data Standards Jun 20, 2024
@johcarter johcarter changed the title Correct Data Type of SoilType from float to tinyint and valid values from [0,) to [0,1] [Property] Correct Data Type of SoilType from float to tinyint and valid values from [0,) to [0,1] Jun 20, 2024
@johcarter
Copy link
Contributor Author

This is a reversion of a breaking change in OED v3.2 to go into OED v.3.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major major release (breaking change)
Projects
Status: Done
Development

No branches or pull requests

1 participant