Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Specification] Formally assign ids to coverages in OED specification #194

Closed
4 tasks
johcarter opened this issue Jun 19, 2024 · 3 comments
Closed
4 tasks

[Specification] Formally assign ids to coverages in OED specification #194

johcarter opened this issue Jun 19, 2024 · 3 comments
Assignees
@johcarter
Labels
minor minor release (non-breaking change)

Comments

@johcarter
Copy link
Contributor

Description

Unique ids (integers) will be assigned to all coverages in the OED specification, although the ids for the new financial coverages will not be embedded in OED fieldnames as they are for property.

Reasons for change

It is useful and practical for standard ids to be assigned to coverages for programming purposes.

Scope of change

A column of ids will be added to the new coverages table in the specification.

  • Location File
  • Accounts File
  • Reinsurance Scope
  • Reinsurance Info

Impact of change

None
@johcarter johcarter added the minor minor release (non-breaking change) label Jun 19, 2024
@johcarter johcarter self-assigned this Jun 19, 2024
@johcarter johcarter moved this to Under discussion in Open Data Standards Jun 19, 2024
@johcarter johcarter changed the title Formally assign ids to coverages in OED specification [Specification] Formally assign ids to coverages in OED specification Jun 19, 2024
@johcarter johcarter moved this from Under discussion to Agreed and ready in Open Data Standards Jun 19, 2024
@johcarter johcarter moved this from Agreed and ready to Under discussion in Open Data Standards Jun 20, 2024
@johcarter johcarter moved this from Under discussion to Agreed and ready in Open Data Standards Jun 20, 2024
@johcarter johcarter moved this from Agreed and ready to Under discussion in Open Data Standards Jun 20, 2024
@johcarter johcarter moved this from Under discussion to Agreed and ready in Open Data Standards Jun 26, 2024
@johcarter johcarter moved this to Under discussion in OED 4.0.0 Jun 26, 2024
@johcarter johcarter moved this from Under discussion to Agreed and ready in OED 4.0.0 Jun 26, 2024
@johcarter johcarter moved this from Agreed and ready to In progress in OED 4.0.0 Jul 10, 2024
johcarter added a commit that referenced this issue Jul 10, 2024
@johcarter
#194 added ids to coverages and explanatory notes for classes of busi…
ae9c060 
…ness
@johcarter johcarter moved this from In progress to In review in OED 4.0.0 Jul 10, 2024
@MattDonovan82
Copy link
Contributor

Agree with these approaches. These notes on how to use the coverages will need to be clear and accessible in the documentation. Moving to done.

@MattDonovan82 MattDonovan82 moved this from In review to Done in OED 4.0.0 Jul 12, 2024
@johcarter
Copy link
Contributor Author

please see https://github.com/OasisLMF/ODS_OpenExposureData/blob/release/4.0.0rc2/OpenExposureData/Docs/Notes.rst#coverage-values

sambles pushed a commit that referenced this issue Jul 17, 2024
@johcarter @sambles
#194 added ids to coverages and explanatory notes for classes of bus…
4bb2c74 
…iness
sambles pushed a commit that referenced this issue Jul 17, 2024
@johcarter @sambles
#194 added ids to coverages and explanatory notes for classes of bus…
a6accfe 
…iness
@johcarter johcarter mentioned this issue Aug 21, 2024
Merged
@johcarter johcarter moved this from Todo to Waiting for Review in Oasis Dev Team Tasks Dec 4, 2024
@aiste-kalinauskaite
Copy link

No impact on clients or model vendors - agreed.

@github-project-automation github-project-automation bot moved this from Agreed and ready to Done in Open Data Standards Jan 9, 2025
@github-project-automation github-project-automation bot moved this from Waiting for Review to Done in Oasis Dev Team Tasks Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johcarter johcarter

Labels
minor minor release (non-breaking change)
Projects
OED 4.0.0
Status: Done
Oasis Dev Team Tasks
Status: Done
Open Data Standards
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johcarter @aiste-kalinauskaite @MattDonovan82