Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference test #1

Open
MDHowe4 opened this issue Nov 10, 2023 · 1 comment
Open

Reference test #1

MDHowe4 opened this issue Nov 10, 2023 · 1 comment

Comments

@MDHowe4
Copy link

MDHowe4 commented Nov 10, 2023

  • Successfully downloaded and tested on mFORGE and ran on unnormalized and log2(TPM+1) normalized RNAseq data

  • On the reference data set I had this error after loading without doing any normalization or modification of imported data:
    Error in riskSignature(expr_input = normalized_expression, background = T) : unused argument (background = T)
    The documentation states that: background - Table consisting of a "universe" of genes analyzed during model training. I think this should just subset expr_input but the exact functionality should be better defined and also did not run in my test. I had to remove the variable to run.

  • A test/return specific to exact data format needed would be useful. The current error return is:
    Error in FUN(X[[i]], ...) : only defined on a data frame with all numeric-alike variables
    which is descriptive on its own, but a custom one can tell the user the exact format of the data required.

  • I recommend adding more documentation to the RiskSignature function. Format can be based on another R package you think is high quality.

  • Maybe create an option in the function to export as CSV or some other data format when run. Could save users a small amount of time. If ambitious could also create/output some summary data, but is not necessary.

@pickledgrape
Copy link
Contributor

On the reference data set I had this error after loading without doing any normalization or modification of imported data:
Error in riskSignature(expr_input = normalized_expression, background = T) : unused argument (background = T)

This is an error in the vignette's suggested usage; indeed, "background" is not called in riskSignature(), but "use_background" is. Updating readME.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants