Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup sending of Nero message #237

Open
jr1221 opened this issue Nov 30, 2024 · 2 comments
Open

Cleanup sending of Nero message #237

jr1221 opened this issue Nov 30, 2024 · 2 comments
Assignees
@jr1221

Comments

@jr1221
Copy link
Contributor

jr1221 commented Nov 30, 2024

Description

Right now nero message is sent in a few spots. That's ugly, we should trigger it periodically in one location preferably not the default task.

Acceptance Criteria

Nero message is sent in one spot.

Proposed Solution

Move around what calls it, possibly move the actual sending of the can message itself.
@jr1221 jr1221 self-assigned this Dec 2, 2024
@jr1221
Copy link
Contributor Author

jr1221 commented Dec 4, 2024

Will include stop spamming state transitions via faults lolol

@jr1221
Copy link
Contributor Author

jr1221 commented Dec 10, 2024

To do this, see my WIP branch linked to this issue (not nearly ready to be merged and out of date).
Also see this pseduocode: https://nu-electric-racing.slack.com/archives/C01D7FG80ET/p1732938738790099

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jr1221 jr1221

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

bug/fix-nero-send Northeastern-Electric-Racing/Cerberus
1 participant
@jr1221