nheko does not render cinny strikethrough

[pennae]

Describe the bug

cinny renders strikethrough to html as <del data-md="~~">, which confuses the hell out of nheko because it textually replace <del> → <s> to render strikethrough. checked that the replacement code is still like this on current master, so we expect it to be broken there too

To Reproduce

1. view a cinny-generated strikethrough

What happened?

it's not struck through

Expected behavior

it being struck through

Screenshots

No response

Version

0.11.3

Operating system

Linux

Installation method

Some repository (AUR, homebrew, distribution repository, PPA, etc)

Qt version

No response

C++ compiler

No response

Desktop Environment

No response

Did you use profiles?

• Profiles used?

Relevant log output

No response

Backtrace

No response

[Mikaela]

Which one performs the replacement, Cinny or Nheko? Either way it seems wrong, unless I am misunderstanding, under

• Document the deprecation policy of HTML tags. matrix-org/matrix-spec#1732
• MSC4077: Improved process for handling deprecated HTML features matrix-org/matrix-spec-proposals#4077

[pennae]

nheko does: https://github.com/Nheko-Reborn/nheko/blob/master/resources/qml/delegates/TextMessage.qml#L41

patching this to replace <del[^>]*?> fixes the problem, but that's a horrid fix and should not go upstream

[deepbluev7]

I strip the attribute out in the sanitization step now, thank you for the report. Sadly Qt does not support the del tag, so some replacement still needs to happen, however the spec suggest to strip out all attributes anyway unless they are allowed and we are doing that for at least del tags now. Thank you for the report! :)