From 83d9d1913182f02a6c62ffa591a8337102391e6e Mon Sep 17 00:00:00 2001
From: KarinaAsmar-NOAA <karina.asmar@noaa.gov>
Date: Thu, 2 Jan 2025 11:41:36 +0000
Subject: [PATCH] fixes: restore err=0, pval initialized, fix psi-to-chi typo

---
 sorc/ncep_post.fd/UPP_PHYSICS.f | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/sorc/ncep_post.fd/UPP_PHYSICS.f b/sorc/ncep_post.fd/UPP_PHYSICS.f
index bc52e99a3..b423abfc6 100644
--- a/sorc/ncep_post.fd/UPP_PHYSICS.f
+++ b/sorc/ncep_post.fd/UPP_PHYSICS.f
@@ -4886,9 +4886,11 @@ SUBROUTINE CALCHIPSI (UWND,VWND,CHI,PSI)
       do jj=1,300 
         call exch(psi(ista_2l:iend_2u,jsta_2l:jend_2u))
         ptmp=psi
+	err=0
         do j=jsta,jend
         do i=ista,iend
           if (j>1 .and. j<jm) then
+            pval=psi(i,j)
             psi(i,j) = 0.25*(ptmp(i-1,j)+ptmp(i+1,j)+ptmp(i,j-1)+ptmp(i,j+1))-atmp(i,j)
             edif=psi(i,j)-pval
             edif=abs(edif)
@@ -4927,11 +4929,13 @@ SUBROUTINE CALCHIPSI (UWND,VWND,CHI,PSI)
       do jj=1,300 
         call exch(chi(ista_2l:iend_2u,jsta_2l:jend_2u))
         ptmp=chi
+	err=0
         do j=jsta,jend
         do i=ista,iend
           if (j>1 .and. j<jm) then
+            pval=chi(i,j)
             chi(i,j) = 0.25*(ptmp(i-1,j)+ptmp(i+1,j)+ptmp(i,j-1)+ptmp(i,j+1))-dtmp(i,j)
-            edif=psi(i,j)-pval
+            edif=chi(i,j)-pval
             edif=abs(edif)
             err=max(edif,err)
           endif