Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aggregate_biomass missing planktivore spring 2024 data point #185

Open
BBeltz1 opened this issue Dec 12, 2024 · 3 comments · Fixed by #182
Open

aggregate_biomass missing planktivore spring 2024 data point #185

BBeltz1 opened this issue Dec 12, 2024 · 3 comments · Fixed by #182
Assignees

Comments

@BBeltz1
Copy link
Collaborator

BBeltz1 commented Dec 12, 2024

No description provided.

@andybeet
Copy link
Member

i think its there!!
At least on some of the branches

dplyr::filter(ecodata::aggregate_biomass, Time == 2024, grepl("lanktivore Spring", 
    Var))
#> # A tibble: 30 × 5
#>     Time Var                                                  Value EPU   Units 
#>    <dbl> <chr>                                                <dbl> <chr> <chr> 
#>  1  2024 Planktivore Spring Biomass Index                     21.9  MAB   kg to…
#>  2  2024 Planktivore Spring Biomass Standard Error             7.32 MAB   kg to…
#>  3  2024 Planktivore Spring Biomass Index - inshore           15.0  MAB   kg to…
#>  4  2024 Planktivore Spring Biomass Standard Error - inshore   6.06 MAB   kg to…
#>  5  2024 Planktivore Spring Biomass Index - offshore          22.6  MAB   kg to…
#>  6  2024 Planktivore Spring Biomass Standard Error - offshore  8.06 MAB   kg to…
#>  7  2024 Planktivore Spring Biomass Index                     44.2  GB    kg to…
#>  8  2024 Planktivore Spring Biomass Standard Error            27.0  GB    kg to…
#>  9  2024 Planktivore Spring Biomass Index - inshore            5.38 GB    kg to…
#> 10  2024 Planktivore Spring Biomass Standard Error - inshore   5.36 GB    kg to…
#> # ℹ 20 more rows

Created on 2024-12-13 with reprex v2.1.0

@BBeltz1
Copy link
Collaborator Author

BBeltz1 commented Dec 13, 2024

It is not plotting. Working on branch comp_docs.

ecodata::plot_aggregate_biomass(report="NewEngland", EPU = "GB")
image

ecodata::plot_aggregate_biomass(report="NewEngland", EPU = "GOM")
image

The 2024 data point is present for all functional groups except for planktivores.

@andybeet do you see the point when you run the same plot arguments?

@andybeet
Copy link
Member

so i found this in the plot code

  ### Planktivore
  p3<-agg_bio |>
    dplyr::filter(stringr::str_detect(Var,"Planktivore"),
                  Time <= 2023) |>
    dplyr::mutate(Mean = dplyr::case_when(Mean >80 ~ 90,
                                           TRUE ~ Mean)) |>

For some reason we are filtering by year. I'll fix

@andybeet andybeet linked a pull request Dec 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants