Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classes and Features Munch missing items/features #147

Open
MaxPat931 opened this issue Jul 5, 2021 · 5 comments
Open

Classes and Features Munch missing items/features #147

MaxPat931 opened this issue Jul 5, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@MaxPat931
Copy link

MaxPat931 commented Jul 5, 2021

Importing Class Features via the Munch is missing items that would be imported via character import, Active Effects also do not import

Individual items for Paladin's Channel Divinities - currently one item "Channel Divinity (Subclass)
Channel Divinity (Paladin)
Channel Divinity: Abjure Enemy
Channel Divinity: Abjure the Extraplanar
Channel Divinity: Champion Challenge
Channel Divinity: Conquering Presence
Channel Divinity: Control Undead
Channel Divinity: Dreadful Aspect
Channel Divinity: Emissary of Peace
Channel Divinity: Fury of the Tides
Channel Divinity: Inspiring Smite
Channel Divinity: Marine Layer
Channel Divinity: Nature's Wrath
Channel Divinity: Peerless Athlete
Channel Divinity: Rebuke the Violent
Channel Divinity: Sacred Weapon
Channel Divinity: Turn the Faithless
Channel Divinity: Turn the Tide
Channel Divinity: Turn the Unholy
Channel Divinity: Turn Undead
Channel Divinity: Watcher’s Will
Channel Divinity: Vow of Enmity

Some Cleric Domain Spell features
Domain Spells (Arcana Domain)
Domain Spells (Death Domain)
Domain Spells (Knowledge Domain)
Domain Spells (Life Domain)
Domain Spells (Light Domain)
Domain Spells (Nature Domain)
Domain Spells (Tempest Domain)
Domain Spells (Trickery Domain)
Domain Spells (War Domain)

Ranger Optional Feature
Primal Companion

There are also several items imported that are listed as subclass options, but are class options (some examples):
Extra Attack
Fighting Style (Echo Knight)
Spellcasting (Armorer)
Timeless Body (Circle of Stars)
Unarmored Defense (Path of the Berserker)

@MrPrimate MrPrimate added the enhancement New feature or request label Jul 5, 2021
@MrPrimate
Copy link
Owner

Hi @MaxPat931 this is a current limitation of the way this is implemented currently and requires a large re-write to improve.

@MrPrimate
Copy link
Owner

I will also break this into 4 issues, as they are different bugs/enhancements to solve.

@MaxPat931
Copy link
Author

Yep, I figured that would be the case. I understand this feature isn't a priority right now, I just wanted to make note of my findings while I was working on it this past week.

@MrPrimate
Copy link
Owner

It's a very useful list, thanks!

@MaxPat931
Copy link
Author

Bonus Proficiencies have been included, some Domain Spells have been included, I've updated the initial comment to reflect that.
Also removed the feature options (ki, invocations, etc) to create a new ticket

@MrPrimate MrPrimate changed the title [Experimental] Classes and Features Munch missing items Classes and Features Munch missing items/features Sep 30, 2022
@MrPrimate MrPrimate pinned this issue Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants