Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Toggle to override master volume with media volume #1225

Open
karst opened this issue Aug 28, 2023 · 8 comments
Open

Feature Request: Toggle to override master volume with media volume #1225

karst opened this issue Aug 28, 2023 · 8 comments
Labels
Enhancement New feature or request

Comments

@karst
Copy link

karst commented Aug 28, 2023

Description of the new feature / enhancement

A new setting (could make the toggle available with a hotkey, too) that will hook in and override a keyboard's volume button to control the current active media's volume instead of the master volume. Needs to be able to directly control the volume inside of media apps (such as Spotify, iTunes, etc) but also on websites (such as YouTube, Netflix, etc). I don't know if there currently is an ability to control an unselected tab, perhaps a chromium/firefox extension would need to be made.

Scenario when this would be used?

While gaming with music in the background or a video/series/movie on the other screen it'd allow you to control the audio of the media without having to tab out. For example quick muting or turning it down in a clutch situation. Or for streamers if they need to talk to the audience etc etc.
As a musician I already have master volume control with my monitor controller which is much more precise than the digital volume bar in windows. It make the currently redundant volume knob on my keyboard actually useful.

Additional context

Might be related to #164

@karst karst added the Enhancement New feature or request label Aug 28, 2023
@manstheram
Copy link
Contributor

The issue is, what if there are multiple media sources playing at the same time? Or, how do we know what app is a media app or a video game? That's why instead of just having media volume and master volume, each app should have a volume option like the Windows mixer. I can also add it so that the app currently on screen is the one the volume changes for.
It may be possible to add a whitelist of media apps, but I'll first need to add in #164 before this one.

@karst
Copy link
Author

karst commented Aug 30, 2023

It'd work the same as all current multimedia keys function. If you press play whatever multimedia is given the priority (which display on the media display) would be the one controlled. I personally find it odd that you can pause, play, skip or revert using the multimedia keys but not change the volume of it.

@manstheram
Copy link
Contributor

That makes sense.

@manstheram
Copy link
Contributor

manstheram commented Aug 30, 2023

Spotify will require the usage of Toastify, but thankfully, that's opensource. I might make the flyouts compatible with Spicetify and make an extension for that.

@manstheram
Copy link
Contributor

I should be able to make an extension for Firefox that edits videos' volume (like for Youtube), but I'm not sure whether Netflix uses the

@manstheram
Copy link
Contributor

Also, how should I show that the media volume toggle is on? Do I leave a permanent popup on screen or should I make it like the lock key flyouts and just a simple icon? @karst

@karst
Copy link
Author

karst commented Aug 30, 2023

Perhaps a popup similar to the insert/overtype mode?

@manstheram
Copy link
Contributor

According to this, I can use WebNowPlaying to control browser sessions, so that's sorted. WebNowPlaying Docs
I can even use it with Spotify using Spicetify and WebNowPIaying-Redux. Not sure whether I can support other apps using these api's but I might as well use this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants