-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
before hooks and async callbacks are not compliant with Meteor 3 promises #308
Comments
Thank you for submitting this issue! We, the Members of Meteor Community Packages take every issue seriously. However, we contribute to these packages mostly in our free time. If you think this issue is trivial to solve, don't hesitate to submit Please also consider sponsoring the maintainers of the package. |
Hey, @StorytellerCZ, how is the MCP work handled? Are you guys assigning issues to people, or is it just going on "free will" of all collaborators? |
free will |
I was planning to solve this under #309 . I just have to figure out if there's an easy way to be both Meteor 2.0 and 3.0 compatible with a lot of c/p code that would be potentially required for sync and async versions of hooks. |
@vincentcarpentier @bhunjadi is this resolved with the |
@jankapunkt Yes, this is resolved. However, we don't have compatibility with Meteor 2.0 because of all the async stuff that's done behind the hood (see Option #2 and explanation here #309 (comment)) |
For example this code cannot works with an async callback without any "await" keyword.
We are not able to cancel updates (nor inserts or deletes) by returning false.
Can you prioritize this feature to allow us complete our refactoring of our code base to Meteor 3 please ? 🙏
The text was updated successfully, but these errors were encountered: