Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing setting timeout in DeepSpeedStrategy #20466

Closed
jedyang97 opened this issue Dec 4, 2024 · 1 comment · Fixed by #20474
Closed

Allowing setting timeout in DeepSpeedStrategy #20466

jedyang97 opened this issue Dec 4, 2024 · 1 comment · Fixed by #20474
Labels
feature Is an improvement or enhancement strategy: deepspeed

Comments

@jedyang97
Copy link
Contributor

jedyang97 commented Dec 4, 2024

Outline & Motivation

In DDPStrategy / FSDPStrategy, the timeout=datetime.timedelta(seconds=1800) flag is exposed and thus allowing user to tune. However, in DeepSpeedStrategy, which is a subclass of DDPStrategy, this flag is not exposed, which makes it hard to change the timeout behavior.

Is there any workaround? Otherwise, I think it might be worth adding kwargs to the __init__() function of DeepSpeedStrategy, and pass along those parameters to the parent class DDPStrategy.

Pitch

No response

Additional context

No response

cc @Borda @awaelchli @justusschock

@jedyang97 jedyang97 added needs triage Waiting to be triaged by maintainers refactor labels Dec 4, 2024
@lantiga
Copy link
Collaborator

lantiga commented Dec 5, 2024

Hey @jedyang97 definitely, do you want to send in a quick PR?

@lantiga lantiga added feature Is an improvement or enhancement strategy: deepspeed and removed needs triage Waiting to be triaged by maintainers refactor labels Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement strategy: deepspeed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants