Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes in README.md #20

Closed
panchbhai1969 opened this issue Jan 20, 2019 · 1 comment · Fixed by #21
Closed

Fixes in README.md #20

panchbhai1969 opened this issue Jan 20, 2019 · 1 comment · Fixed by #21

Comments

@panchbhai1969
Copy link
Contributor

panchbhai1969 commented Jan 20, 2019 •
edited
Loading

It may seem trivial, but README.md files are the first point of information that a parson refers to when trying to understand a project, The repository's README.md is good, but i have found some error that need attention.

NUMLINES= $(echo awk '{ print $1}' | cat data/monument_300/data_300.sparql | wc -l)
There shouldn't be any space after =, the line should be :
NUMLINES=$(echo awk '{ print $1}' | cat data/monument_300/data_300.sparql | wc -l)

Other README.md related issues and suggestions brought up by users are #12 #14 #17
panchbhai1969 added a commit to panchbhai1969/NSpM that referenced this issue Jan 20, 2019
@panchbhai1969
Readme change for LiberAI#20, LiberAI#12 and other issues encountered…
8383a87 
… during ruuning the code by following the instructions on current README.md (These issues and changes are commented in the README.md file)
@panchbhai1969 panchbhai1969 mentioned this issue Jan 20, 2019
Merged
@thisisshub
Copy link

thisisshub commented Mar 12, 2020 •
edited
Loading

@panchbhai1969
I believe #14 still isn't solved or mentioned in the current README.md. Should I make a PR to assess the required changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes in README.md panchbhai1969/NSpM
2 participants
@panchbhai1969 @thisisshub