From a98097c0c60e12dcbf6689bdee1d42448acfefa4 Mon Sep 17 00:00:00 2001
From: Maxence Gollier <mgollier45@gmail.com>
Date: Mon, 22 Jul 2024 10:22:07 +0200
Subject: [PATCH] Apply suggestions

---
 docs/src/tutorials/qless.md | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/docs/src/tutorials/qless.md b/docs/src/tutorials/qless.md
index 08f6404..7c9d5e6 100644
--- a/docs/src/tutorials/qless.md
+++ b/docs/src/tutorials/qless.md
@@ -1,22 +1,24 @@
 ```@example qless1
 using QRMumps, LinearAlgebra, SparseArrays, Printf
 
+m, n = 5, 7
 irn = [1, 3, 5, 2, 3, 5, 1, 4, 4, 5, 2, 1, 3]
 jcn = [1, 1, 1, 2, 3, 3, 4, 4, 5, 5, 6, 7, 7]
 val = [1.0, 2.0, 3.0, 1.0, 1.0, 2.0, 4.0, 1.0, 5.0, 1.0, 3.0, 6.0, 1.0]
 
-A = sparse(irn, jcn, val, 5, 7)
+A = sparse(irn, jcn, val, m, n)
 b = [40.0, 10.0, 44.0, 98.0, 87.0]
 y_star = [0.0, 1.0, 2.0, 3.0, 4.0]
-y₁ = similar(b,7)
-y₂ = similar(b)
+y₁ = zeros(n)
+y₂ = zeros(m)
 
 qrm_init()
 
 spmat = qrm_spmat_init(A)
 spfct = qrm_spfct_init(spmat)
-qrm_analyse!(spmat, spfct; transp='t')
+
 qrm_set(spfct, "qrm_keeph", 0)
+qrm_analyse!(spmat, spfct; transp='t')
 qrm_factorize!(spmat, spfct, transp='t')
 
 qrm_solve!(spfct, b, y₁; transp='t')
@@ -30,11 +32,12 @@ error_norm = norm(y₂ - y_star)
 ```@example qless2
 using QRMumps, LinearAlgebra, SparseArrays, Printf
 
+m, n = 7, 5
 irn = [1, 1, 1, 2, 3, 3, 4, 4, 5, 5, 6, 7, 7]
 jcn = [1, 3, 5, 2, 3, 5, 1, 4, 4, 5, 2, 1, 3]
 val = [1.0, 2.0, 3.0, 1.0, 1.0, 2.0, 4.0, 1.0, 3.0, 1.0, 3.0, 2.0, 1.0]
 
-A = sparse(irn, jcn, val, 7, 5)
+A = sparse(irn, jcn, val, m, n)
 b = [22.0, 2.0, 13.0, 8.0, 17.0, 6.0, 5.0]
 x_star = [1.0, 2.0, 3.0, 4.0, 5.0]