Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NystromFact need to be reparametrized #428

Open
theogf opened this issue Jan 27, 2022 · 1 comment
Open

NystromFact need to be reparametrized #428

theogf opened this issue Jan 27, 2022 · 1 comment

Comments

@theogf
Copy link
Member

theogf commented Jan 27, 2022

I don't know if this should be done in this PR. But NystromFact is awfully parametrized.

Originally posted by @theogf in #427 (comment)

@st--
Copy link
Member

st-- commented Jan 28, 2022

can you explain in a bit more detail what about the parametrisation is so bad ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants