Trial display assumes the max GC comes from the sample with the max time

[mbauman]

If I followed the breadcrumbs here right, the displayed max GC time comes from the maximum as computed here:

BenchmarkTools.jl/src/trials.jl

Lines 116 to 119 in 7eebf01

	function Base.maximum(trial::Trial)
	i = argmax(trial.times)
	return TrialEstimate(trial, trial.times[i], trial.gctimes[i])
	end

Which isn't really the maximum GC time. Since it's displayed independently, this can be surprising.

Cf. https://discourse.julialang.org/t/time-and-benchmark-give-different-results/66374/3

[vchuravy]

In BenchmarkTools GC time is always printed as a ratio. That's why we do gcratio(maximum(trial)).

So yes the fact that we say the "maximum GC" is 0.0% is confusing

See discussion in #250 as well.