Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use flags to build geometry instead of relying on experiment name #9

Open
leadmocha opened this issue Jun 7, 2016 · 0 comments
Open

Comments

@leadmocha
Copy link
Member

Right now we have a few scattered conditionals that check for some experiment names to decide what to build. But these are scattered across the different source files.

I think we should, instead, make flags that get configured in just one file. Ex:

if (kGEp) {
fBuild48D48 = true;
fBuildTargetSnout = true;
// ...
} else if (kGMn) {
fBuild48D48 = true;
fBuildTargetSnout = false;
// ...
}

That way, all the settings are in one file, and can be re-configured much quicker and hopefully, with less errors.

leadmocha added a commit that referenced this issue Jul 12, 2016
effort to make the experiment configurations more evident, similar to
how the EArm is built right now.

This addresses some of the concerns in issue #9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant