Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugs in soca2cice call of icepack cleanup #1117

Open
shlyaeva opened this issue Jan 13, 2025 · 1 comment · May be fixed by #1118
Open

bugs in soca2cice call of icepack cleanup #1117

shlyaeva opened this issue Jan 13, 2025 · 1 comment · May be fixed by #1118
Assignees
@shlyaeva
Labels
bug Something is not working SOCA Sea-ice, Ocean, and Coupled Assimilation

Comments

@shlyaeva
Copy link
Contributor

Description

There's a bug in how tracers are passed to cleanup_itd, resulting in messed up tracers after shifting ice between categories.
The good news is that there's another bug in how cleanup_itd is used in soca2cice: the tracers are not put back into the analysis fields after cleanup, so it doesn't matter that they are messed up. 🤦‍♀
@shlyaeva shlyaeva added bug Something is not working SOCA Sea-ice, Ocean, and Coupled Assimilation labels Jan 13, 2025
@shlyaeva shlyaeva self-assigned this Jan 13, 2025
@guillaumevernieres
Copy link
Contributor

Bug cancellation is an important part of my development philosophy as well @shlyaeva .

@shlyaeva shlyaeva linked a pull request Jan 13, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shlyaeva shlyaeva

Labels
bug Something is not working SOCA Sea-ice, Ocean, and Coupled Assimilation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfixes for icepack cleanup in Soca2Cice JCSDA-internal/soca
2 participants
@guillaumevernieres @shlyaeva