Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better keyHashToText and scriptHashToText reuse in command #289

Open
paweljakubas opened this issue Dec 24, 2024 · 0 comments
Open

Better keyHashToText and scriptHashToText reuse in command #289

paweljakubas opened this issue Dec 24, 2024 · 0 comments
Assignees
Labels
haskell PR:IMPROVING CODE Mark a PR as an improvement, for auto-generated CHANGELOG

Comments

@paweljakubas
Copy link
Collaborator

Context

We have hrp definition in scriptHashToText and keyHashToText but in some command, which should use them, we have redefinition of them, ie. duplication. Also in Cardano.Address.Script we have both script, script hashes and key hashes. Which is not so good domain separation.

Decision

  1. We have separate module Cardano.Address.KeyHash
  2. In Command.Key.Hash we resign from redefining of hrp transitions but reuse what is in keyHashToText
  3. Extend KeyRole to include PaymentShared and DelegationShared

Acceptance Criteria


Development

QA

@paweljakubas paweljakubas self-assigned this Dec 24, 2024
@paweljakubas paweljakubas added haskell PR:IMPROVING CODE Mark a PR as an improvement, for auto-generated CHANGELOG labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
haskell PR:IMPROVING CODE Mark a PR as an improvement, for auto-generated CHANGELOG
Projects
None yet
Development

No branches or pull requests

1 participant