-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submit after percent played #72
Comments
This feature definitely makes sense! Thanks for the suggestion. Do you want to be able to use both |
Yes, both at the same time would be ideal, with the submission happening at whichever value is the highest. The edge cases would be when the It would also be nice to be able to toggle that behavior to submit the track in the event that |
Just to follow up, it seems that One side effect of using an absolute minimum play duration is that if set too low relative to a track's length, for example, if set to 3 minutes, and the track is 7 minutes, once I'm over the 3 minutes mark, and I pause, and play again, it'll end up having 2 scrobbles, one at 3 minute mark and one at 6 minute mark, because there are two 3 minutes "sessions" but I have actually listened to the track once. |
Correct, I haven't really had time to implement min-play-percent. Looking at it now, I'm not even sure why I implemented an absolute time instead of a percentage in the first place. It does seem like some people use it, so I'll have to think about a good way to take both into account. |
Since there's been some discussion here in regards to when to scrobble, I thought I'd chime in with Last.FM's definition of a scrobble.
ListenBrainz follows the same guideline, except the minimum track length. Most scrobblers I've used allow these limits to be customized, but the overall behaviour of scrobbling when the first limit is reached is consistent between all clients. |
It would be nice to have an option like
min-play-percent
that would be used something likemin-play-percent-in-seconds = ( min-play-percent / 100 ) * ( mpris:length / 1000000 )
Then have the submission time used be
min-play-percent-in-seconds
ormin-play-time
, whichever is set and has the highest value.This would let a user retain an absolute minimum while adding a relative minimum, giving better control over only scrobbling what you're actually listening to.
I have 10 minute+ tracks that I'll decide I don't want to listen to 30 seconds in, as well as tracks that are 30 seconds. Setting an absolute minimum of 30 seconds would make the scrobbler blind to my shorter tracks and risk scrobbling longer tracks I'm not really listening to.
The text was updated successfully, but these errors were encountered: