-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New API: Add API end point to copy language-pack to Dataverse Installation #5806
Comments
Hi @JayanthyChengan - is this something that you're working on or are planning to work on? |
@djbrooke : I am working on it and will submit PR soon |
Awesome, thanks @JayanthyChengan ! |
@JayanthyChengan thanks for the pull request! I'm excited to try this out but I requested changes, docs, specifically. Thank you!! This work is very timely because @pkiraly just gave us a lot of great feedback at https://groups.google.com/d/msg/dataverse-community/AgYRCOz1Tlk/ex66tU9FAwAJ |
@JayanthyChengan - I'm moving this back to code review for some doc changes. Please let us know when it's ready for another code review pass. Thanks! |
In 5a8c18d I added @JayanthyChengan 's write up to a new "Internationalization" section of the config section of the Installation Guide. I tried it out on dev2 and it seemed to work. @JayanthyChengan heads up that I looks some liberties to re-write and add what I hope is clarity. 😄 Off to QA! Thanks! |
Thanks @pdurbin |
@JayanthyChengan: great work, congratulation! For me it is still open question if the language pack should or should not contain the original language property files available in the Dataverse core. Don't you want to cover dataverse-docker repository's language properties as well? Or maybe move the language files from there to the now referenced repository? (I include @4tikhonov into this discussion.) |
@pkiraly yes, I believe the English files are required. Please see #5793 and this note that I left in the guides (I just highlighted the important part in my browser): And yes, we absolutely want the languages in the dataverse-docker repo. Please see this issue I just opened (and please feel free to work on it if you'd like! 😄 ): GlobalDataverseCommunityConsortium/dataverse-language-packs#10 |
separate header for loading lang zip #5806
Create an API call to copy the property files from https://github.com/GlobalDataverseCommunityConsortium/dataverse-language-packs to the dataverse.lang.directory path specified in dataverse installation.
The text was updated successfully, but these errors were encountered: