Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OptimizationResultHDF5Writer should allow writing individual OptimzerResults #1527

Open
dweindl opened this issue Nov 27, 2024 · 0 comments
Open

OptimizationResultHDF5Writer should allow writing individual OptimzerResults #1527

dweindl opened this issue Nov 27, 2024 · 0 comments
Assignees
@dweindl
Labels
enhancement New feature or request fixed but not released

Comments

@dweindl
Copy link
Member

dweindl commented Nov 27, 2024

Currently it's not possible to save several OptimizerResults incrementally using OptimizationResultHDF5Writer. The full set has to be written at once. (overwrite=False would result in an error, overwrite=True would delete the previously stored ones).
Ideally, OptimizationResultHDF5Writer would allow storing individual OptimizerResults.
@dweindl dweindl added the enhancement New feature or request label Nov 27, 2024
@dweindl dweindl self-assigned this Nov 27, 2024
@dweindl dweindl mentioned this issue Nov 27, 2024
Merged
dweindl added a commit to dweindl/pyPESTO that referenced this issue Nov 27, 2024
@dweindl
Previously, only writing Result was supported.
7e45441 
Changes:
*  `OptimizeResult`, `OptimizerResult`(s) can be written by `OptimizationResultHDF5Writer.write()` (Closes ICB-DCM#1526)
*  `OptimizerResult`s can be written incrementally by `OptimizationResultHDF5Writer.write_optimizer_result()` (Closes ICB-DCM#1527)
* Fixed an `AttributeError` in `pypesto.store.save_to_hdf5.check_overwrite` with `h5py.Group`s
github-merge-queue bot pushed a commit that referenced this issue Nov 28, 2024
@dweindl
Previously, only writing Result was supported. (#1528)
861318a 
Changes:
*  `OptimizeResult`, `OptimizerResult`(s) can be written by `OptimizationResultHDF5Writer.write()` (Closes #1526)
*  `OptimizerResult`s can be written incrementally by `OptimizationResultHDF5Writer.write_optimizer_result()` (Closes #1527)
* Fixed an `AttributeError` in `pypesto.store.save_to_hdf5.check_overwrite` with `h5py.Group`s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dweindl dweindl

Labels
enhancement New feature or request fixed but not released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dweindl @PaulJonasJost